Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: grpc server address does not follow app.toml #18172

Closed
1 task done
JoowonYun opened this issue Oct 19, 2023 · 4 comments · Fixed by #18254
Closed
1 task done

[Bug]: grpc server address does not follow app.toml #18172

JoowonYun opened this issue Oct 19, 2023 · 4 comments · Fixed by #18254
Assignees
Labels

Comments

@JoowonYun
Copy link
Contributor

JoowonYun commented Oct 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

There is a config in app.toml that can set the address of the grpc server.

In most cases, 127.0.0.1 will be used, but there are sometimes when internal IP or DNS must be used depending on internal policy.

grpcAddress := fmt.Sprintf("127.0.0.1:%s", port)

At that point the problem occur. Is there any other reason to hard code it?

Cosmos SDK Version

0.46, 0.47 and main

How to reproduce?

No response

@alexanderbez
Copy link
Contributor

So what's the exact problem?

@JoowonYun
Copy link
Contributor Author

We are running multiple cosmos nodes on one machine.

Without changing the port, we want to specify an internal IP and listen to 9090 grpc for each specific address.

For example,
gaia : 10.1.1.10:9090
juno : 10.1.1.11:9090

There is an IP that grpc listens to in app.toml, but I am curious as to whether hard coding is used instead of using the value.

@tac0turtle
Copy link
Member

dont see a reason to hardcode it, we can just default it 127.0.0.1

@JoowonYun
Copy link
Contributor Author

dont see a reason to hardcode it, we can just default it 127.0.0.1

The current code does not use the default value. In the grpc address value of app.toml, the address is ignored and only the port is used. And it uses the hard coded address 127.0.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants