Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Integration #18466

Closed
Tracked by #17041
alexanderbez opened this issue Nov 14, 2023 · 5 comments
Closed
Tracked by #17041

Framework Integration #18466

alexanderbez opened this issue Nov 14, 2023 · 5 comments
Assignees
Labels

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 14, 2023

This issue is to mainly track the requirements needed in order to integrate store v2 into the wider SDK framework. I.e. replace store v1 usage with store v2 usage. This will most likely require rewiring of the sdk.Context type and perhaps other bits of refactoring.

cc @tac0turtle

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Nov 14, 2023
@alexanderbez alexanderbez added C:Store and removed needs-triage Issue that needs to be triaged labels Nov 14, 2023
@robert-zaremba
Copy link
Collaborator

Initially, when we were researching store/v2 we had a big push back for the Context upgrade. A pattern I proposed to avoid Context update was creating accessor functions. I started drafting it 2 years ago in this branch: robert/context-accessor.

@alexanderbez
Copy link
Contributor Author

Initially, when we were researching store/v2 we had a big push back for the Context upgrade.

Yeah, I can see that.

@fdymylja tells me integration should be trivial w/ the new services/runtime stuff. Will be syncing with him shortly. But yes, I do want to avoid touching Context as much as possible 👍

@robert-zaremba
Copy link
Collaborator

BTW, here is the "accessor pattern" draft: fc71bf4

@alexanderbez
Copy link
Contributor Author

Happening in parallel with server/v2 work.

@tac0turtle
Copy link
Member

interfaces are aligned, we should be unblocked on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

4 participants