Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the internal module from store #18738

Closed
Tracked by #17041
cool-develope opened this issue Dec 13, 2023 · 0 comments · Fixed by #18944
Closed
Tracked by #17041

Remove the internal module from store #18738

cool-develope opened this issue Dec 13, 2023 · 0 comments · Fixed by #18944
Assignees
Labels

Comments

@cool-develope
Copy link
Contributor

cool-develope commented Dec 13, 2023

Context

We'd like to avoid the cometbft/protof/tendermint/crypto imports in the store module for loose coupling (without specifying the proof format). Also, there was a discussion of the wrong format with the ProofFromMap which is used in the multi store proof.

Decision

We will implement the own proof format without the store/internal module.

Reference

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 13, 2023
@cool-develope cool-develope self-assigned this Dec 13, 2023
@cool-develope cool-develope changed the title Re-evaluate root hash construction (https://github.com/cosmos/cosmos-sdk/issues/13534) Remove the internal module from store Dec 14, 2023
@tac0turtle tac0turtle added C:Store and removed needs-triage Issue that needs to be triaged labels Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants