Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of shares from client returns #3516

Closed
jackzampolin opened this issue Feb 6, 2019 · 2 comments · Fixed by #3857
Closed

Remove mentions of shares from client returns #3516

jackzampolin opened this issue Feb 6, 2019 · 2 comments · Fixed by #3857
Assignees
@alexanderbez
Labels
S:proposed T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
v0.34.0
Milestone
v0.34.0

Comments

@jackzampolin
Copy link
Member

Ref: luniehq/lunie#1931
@jackzampolin jackzampolin mentioned this issue Feb 6, 2019
Closed
@faboweb
Copy link
Contributor

faboweb commented Feb 11, 2019

Summing up:
Clients should not care about the internal concept of shares.
I as a user only want to know how many tokens I have delegated to a validator so I can quickly evaluate how much value I have delegated.
Same: I as a user want to withdraw x tokens I have delegated to a validator.

Therefor in the CLI and REST interface displaying and withdrawing (and redelegation?!) of stake should only happen in tokens. Those tokens are then converted into and from shares internally.

@rigelrozanski rigelrozanski added T: Dev UX UX for SDK developers (i.e. how to call our code) API labels Feb 14, 2019
@rigelrozanski
Copy link
Contributor

makes ample sense - some consideration needs to given based truncation which may occur based on values of shares etc.. but I don't think it's anything unmanageable

@jackzampolin jackzampolin mentioned this issue Mar 1, 2019
Closed
4 tasks
@alexanderbez alexanderbez self-assigned this Mar 11, 2019
@alexanderbez alexanderbez mentioned this issue Mar 11, 2019
Merged
5 tasks
@jackzampolin jackzampolin added this to To do in v0.34.0 Mar 19, 2019
@alexanderbez alexanderbez moved this from To do to Review in v0.34.0 Mar 21, 2019
v0.34.0 automation moved this from Review to Done Mar 25, 2019
@joe-bowman joe-bowman mentioned this issue Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
S:proposed T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
No open projects
v0.34.0
  
Done
Milestone
v0.34.0
Development

Successfully merging a pull request may close this issue.

Remove Shares Concept from Unbond/Redelegate UX cosmos/cosmos-sdk
4 participants
@alexanderbez @faboweb @jackzampolin @rigelrozanski