Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation: Params from File #4428

Closed
4 tasks
alexanderbez opened this issue May 28, 2019 · 5 comments · Fixed by #4435
Closed
4 tasks

Simulation: Params from File #4428

alexanderbez opened this issue May 28, 2019 · 5 comments · Fixed by #4435
Assignees

Comments

@alexanderbez
Copy link
Contributor

Summary

Simulation should have the ability to execute from a predefined set of parameters. This will allow for more reproducible runs and execution paths. The simulation test will have a top level structure of parameter stores and keys. Given a file, if an given subspace/key exists, it'll be used. Otherwise, it'll generate a pseudo-random one as it does now.

/cc @npinto @rigelrozanski


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rigelrozanski
Copy link
Contributor

So already we can already simulate from a genesis file (see #3182) which allows us to include custom parameters. However it may also be nice to have something a bit more flexible in code

@alexanderbez
Copy link
Contributor Author

alexanderbez commented May 28, 2019

Correct @rigelrozanski but I'd essentially would like to decouple that. ie. consume params from file and simulating state.

So you can essentially run simulation in three ways:

  1. Raw; no params and no genesis inputs (what CI does)
  2. Raw w/ Params input; implicitly will not allow genesis as input
  3. Raw w/ Genesis input; implicitly will not allow params as input

@npinto
Copy link
Contributor

npinto commented May 28, 2019

This is great ;-) cc: @fernand

@rigelrozanski
Copy link
Contributor

@alexanderbez yup that set of options seems good - I'm a bit confused as to what the format of a params file would look like though? (is that not effectively a genesis file? what's different) - if you're referring to a custom param set defined in code then this makes sense to me once again.

@alexanderbez
Copy link
Contributor Author

Yeah precisely @rigelrozanski. The params file is just a flat JSON file of key/values. Because simulation generates random parameters outside of just modules (e.g. amount of tokens per account), the genesis file won't cut it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants