Add an ability to update ConsensusParams

[whylee259]

Summary

Adding an ability to update ConsensusParams by collecting ConsensusParamUpdates from Module.EndBlock.

Problem Definition

Updating ConsensusParams can be done by passing changes to Tendermint through ResponseEndBlock.

We can decide whether to change using the governance module.

However, ModuleManager does not collect ConsensusParamUpdates nor passes them to Tendermint because the interface of AppModule.EndBlock returns only ValidatorUpdate.

cosmos-sdk/types/module/module.go

Lines 312 to 334 in 80be503

	func (m *Manager) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) abci.ResponseEndBlock {
	ctx = ctx.WithEventManager(sdk.NewEventManager())
	validatorUpdates := []abci.ValidatorUpdate{}
	for _, moduleName := range m.OrderEndBlockers {
	moduleValUpdates := m.Modules[moduleName].EndBlock(ctx, req)
	// use these validator updates if provided, the module manager assumes
	// only one module will update the validator set
	if len(moduleValUpdates) > 0 {
	if len(validatorUpdates) > 0 {
	panic("validator EndBlock updates already set by a previous module")
	}
	validatorUpdates = moduleValUpdates
	}
	}
	return abci.ResponseEndBlock{
	ValidatorUpdates: validatorUpdates,
	Events: ctx.EventManager().ABCIEvents(),
	}
	}

Proposal

• AppModule.EndBlock returns ConsensusParamUpdates also.
• passes it to Tendermint

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

The SDK now manages consensus parameters via the x/params module and are changed via governance proposals. That being said, we should probably figure out if we need to send these to Tendermint at all.

Do we need to @marbar3778 @melekes ?

[tac0turtle]

yes they should be sent to Tendermint. If not then while the application changes the params the Tendermint logic will adhere to the genesis consensus params and this may cause problems

[whylee259]

Any schedule to handle this issue?

[tac0turtle]

Add this to #6365 as it should be done prioir to the next major release

[alexanderbez]

What do you mean @marbar3778 -- this was already done. #5952

[tac0turtle]

The SDK now manages consensus parameters via the x/params module and are changed via governance proposals. That being said, we should probably figure out if we need to send these to Tendermint at all.

ah based off this comment I thought it wasn't

[whylee259]

The SDK now manages consensus parameters via the x/params module and are changed via governance proposals. That being said, we should probably figure out if we need to send these to Tendermint at all.

ah based off this comment I thought it wasn't

As @marbar3778 said, this issue is not done. I agree with him.
PTAL @alexanderbez

[alexanderbez]

What do you mean it's not done? I pointed to the PR that completes the work => #5952

[tac0turtle]

ConsensusParams should be updated in Endblock via:

`ConsensusParamUpdates (ConsensusParams)`: Changes to consensus-critical time, size, and other parameters.

This is not implemented yet.