Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Separate x/auth and vesting #9958

Closed
1 task done
aaronc opened this issue Aug 17, 2021 · 4 comments
Closed
1 task done

EPIC: Separate x/auth and vesting #9958

aaronc opened this issue Aug 17, 2021 · 4 comments
Labels
C:x/auth S:needs architecture Needs a architecture proposal for how the feature will be implemented T:Epic Epics

Comments

@aaronc
Copy link
Member

aaronc commented Aug 17, 2021

Summary

As we know, x/auth is overloaded. It's primary functionality should be account authentication. But it contains much more.

Problem Definition

Recently we had a problem with x/auth migration where vesting account were vanished: #10591

Related:

Proposal

Move vesting account feature from x/auth to x/vesting and enable more feature development in a new module.

@alexanderbez
Copy link
Contributor

So what are the concrete action items you had in mind @aaronc? We have a series of SDK issues that relate to vesting and I think we should create a checklist in this main issue that references them, treating this issue as an epic.

For starters, should we start by copying all vesting types to their own Go module?

@aaronc
Copy link
Member Author

aaronc commented Jan 24, 2022

A stand-alone go module is nice but maybe premature since we don't have the new app wiring ready yet.

The two main things that would be nice to see IMHO are pulling it out of auth and allowing multiple locks per account. I.e. it should be possible to send a new bunch of vesting tokens to any existing account. The challenge is figuring out how to do this in a way that doesn't allow spam. There's been some prior design work. @AmauryM do you have meeting notes from when we last looked into this?

@bretheren
Copy link

A stand-alone go module is nice but maybe premature since we don't have the new app wiring ready yet.

The two main things that would be nice to see IMHO are pulling it out of auth and allowing multiple locks per account. I.e. it should be possible to send a new bunch of vesting tokens to any existing account. The challenge is figuring out how to do this in a way that doesn't allow spam. There's been some prior design work. @AmauryM do you have meeting notes from when we last looked into this?

Yeah, this would be awesome. Is there any plan to work on vesting to make it possible to send different vesting tokens to any existing account?

@tac0turtle tac0turtle changed the title Separate x/auth and vesting EPIC: Separate x/auth and vesting Jan 2, 2023
@tac0turtle tac0turtle added the T:Epic Epics label Jan 2, 2023
@tac0turtle
Copy link
Member

close in favour of #18782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/auth S:needs architecture Needs a architecture proposal for how the feature will be implemented T:Epic Epics
Projects
Status: 🥳 Done
Development

No branches or pull requests

5 participants