Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure repository / packages #62

Closed
liamsi opened this issue Jun 16, 2018 · 2 comments
Closed

Restructure repository / packages #62

liamsi opened this issue Jun 16, 2018 · 2 comments
Milestone

Comments

@liamsi
Copy link
Contributor

liamsi commented Jun 16, 2018

Currently, every file lives in the root directory. We need to refactor the code such that different logical parts live in different packages. This will also help clarifying the exposed API.

@erikgrinaker
Copy link
Contributor

I don't think we should do this. We might consider it for internal code (which should go in the special internal package), but I find it ergonomic and idiomatic to keep libraries like these in a single package - see e.g. BadgerDB, BoltDB, and Google B-tree as examples of Go data stores which also do this.

@tac0turtle
Copy link
Member

closing this as IAVL is partially in maintenance, no need to change things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants