Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need separate getters for cast return types? #93

Closed
UnitylChaos opened this issue Aug 1, 2018 · 2 comments
Closed

Do we need separate getters for cast return types? #93

UnitylChaos opened this issue Aug 1, 2018 · 2 comments
Assignees

Comments

@UnitylChaos
Copy link
Contributor

We currently have multiple similar getter methods, such as Get64, Has64, Version64, etc. with corresponding methods Get, Has, Version, etc. which return regular ints.

Are these needed for some specific reason? or is it just to avoid user side casting to int?

cc @liamsi

@liamsi
Copy link
Contributor

liamsi commented Aug 7, 2018

I do not know why they are there. As mentioned while reviewing your PR, I think we should remove the ones that cast to int.

@erikgrinaker
Copy link
Contributor

I believe this was fixed with #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants