Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent when formatting enums #3946

Open
2 of 3 tasks
DimitrisJim opened this issue Jun 23, 2023 · 3 comments · May be fixed by #6291
Open
2 of 3 tasks

Be consistent when formatting enums #3946

DimitrisJim opened this issue Jun 23, 2023 · 3 comments · May be fixed by #6291
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jun 23, 2023 •
edited

Summary

There's mixed usage when formatting enums in our error wrapping, older code seems to use .String() while newer code does not. The result is the same (since we do not implement Format on them).

Would be nice to be consistent with this and probably use the version w/o the explicit calls to .String().

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 23, 2023
@DimitrisJim
Copy link
Contributor Author

note: should probably be done after 04-channel-upgrades is merged.

@faddat
Copy link
Contributor

faddat commented Jun 23, 2023

Hey Jim, I've noticed that there are a lot of issues that I could handle here, and I'm really happy to do so. Just a quick FYI for you and the ibc team, I have very very pending baby coming, so I may be in and out but happy to handle some of these on a best effort basis :).

@DimitrisJim
Copy link
Contributor Author

Very much appreciated @faddat. Yeah there's a couple of issues with code hygiene that are popping up but since fresh upgradability code is still baking in the 04-channel-upgrades branch it would be best to get these all in the end to reduce effort for people making the change and people reviewing.

Grats on the growing family 💪 be sure to take your time as needed!

@DimitrisJim DimitrisJim mentioned this issue Jul 5, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim mentioned this issue Aug 16, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jan 16, 2024
@tropicaldog tropicaldog linked a pull request May 11, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(04-channel): be consistent when formatting enums notional-labs/ibc-go
3 participants
@crodriguezvega @faddat @DimitrisJim