Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS4: sendPacket should add a check to ensure client is not frozen #555

Open
colin-axner opened this issue Mar 30, 2021 · 2 comments · May be fixed by #1051
Open

ICS4: sendPacket should add a check to ensure client is not frozen #555

colin-axner opened this issue Mar 30, 2021 · 2 comments · May be fixed by #1051
Assignees
@sangier
Labels
implementation Tracking an external implementation of the spec. tao Transport, authentication, & ordering layer.

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Mar 30, 2021 •
edited by crodriguezvega

Currently the spec assumes that all the client Verify functions ensure that the client is not frozen. The problem is that the sendPacket function does not call any verify functions. This allows packets to be sent with frozen clients. In the token transfer case, if the packet is never received, the tokens sent are lost since a timeout can never be processed.

We check for this situation in the code. Given that the spec makes a reference to client freezing in 02-client, I think it is ok to add this check into sendPacket.

I also would like this to check to match the proposed change in ibc-go which would prevent users from sending funds on expired clients
@cwgoes
Copy link
Contributor

cwgoes commented Mar 30, 2021

Yes, both changes make sense to me.

@cwgoes cwgoes self-assigned this Mar 30, 2021
@colin-axner
Copy link
Contributor Author

As a part of this issue, IsFrozen checks in light clients may be removed as it should be checked in 02, 03, and 04 before doing any verification, updates, or misbehaviour processing

@cwgoes cwgoes removed their assignment Sep 25, 2021
@mpoke mpoke changed the title 04-channel sendPacket should add a check to ensure client is not frozen ICS4: sendPacket should add a check to ensure client is not frozen Mar 17, 2022
@mpoke mpoke added tao Transport, authentication, & ordering layer. implementation Tracking an external implementation of the spec. labels Mar 17, 2022
@sangier sangier self-assigned this Dec 11, 2023
@sangier sangier linked a pull request Dec 13, 2023 that will close this issue
Open
@sangier sangier linked a pull request Dec 13, 2023 that will close this issue
ics4-add active client check in sendpacket #1051
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangier sangier

Labels
implementation Tracking an external implementation of the spec. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ics4-add active client check in sendpacket cosmos/ibc
4 participants
@mpoke @cwgoes @colin-axner @sangier