Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS05: Allow application multiplexing on portID #890

Open
AdityaSripal opened this issue Nov 30, 2022 · 2 comments
Open

ICS05: Allow application multiplexing on portID #890

AdityaSripal opened this issue Nov 30, 2022 · 2 comments
Labels
feature Possible future feature. tao Transport, authentication, & ordering layer.

Comments

@AdityaSripal
Copy link
Member

With the advent of ICS30, many applications are already using a single port by forming a chain of ICS26 callbacks.

If we bring this behaviour into core IBC, by allowing multiple modules to register sequentially onto the port, we can reduce middleware complexity and allow for more custom behaviour.

Primarily, we may wish to allow packet data to contain data intended for multiple modules. This can get completely unmarshalled at the start and then passed through the different modules in a deterministic order.

@ethanfrey
Copy link
Contributor

With the advent of ICS30, many applications are already using a single port by forming a chain of ICS26 callbacks.

I must admit I don't follow this repo closely, but I do understand IBC and the middleware (ICS30) design. I have not yet seen callbacks used (afaik, the callbacks for ICA is still not implemented) and don't understand the design pattern you are proposing here either.

Could you please link to a document on the design pattern this proposes and how it should work.
I mean, trivially I would think the ICS26 router owns the port and everyone else just registers on it, not on the port itself.

In general, I am afraid you are adding features people don't yet comprehend. While not adding features needed by many projects. Please clarify use cases (and users) before adding more such features. Especially if justified by "many applications are already using..."

@crodriguezvega crodriguezvega added tao Transport, authentication, & ordering layer. feature Possible future feature. labels Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Possible future feature. tao Transport, authentication, & ordering layer.
Projects
None yet
Development

No branches or pull requests

4 participants
@ethanfrey @crodriguezvega @AdityaSripal and others