Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the e2e framework to take traces as an input #1240

Closed
Tracked by #2435
, #1238
...
p-offtermatt opened this issue Aug 25, 2023 · 1 comment · Fixed by #1313, #1314 or #1318
Closed
Tracked by #2435
, #1238
...

Modify the e2e framework to take traces as an input #1240

p-offtermatt opened this issue Aug 25, 2023 · 1 comment · Fixed by #1313, #1314 or #1318
Assignees
@p-offtermatt
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented Aug 25, 2023 •
edited
Loading

The e2e framework should have a way to read and execute test traces given in a file.
Currently, the only way to write test traces is as go code, and this is messy to generate e.g. in MBT.
The proposition is to use a basic JSON format, but the exact format is not particularly important, as long as it is reasonable.
Noone depends on this (yet), and we can always (and will probably need to, due to different abstraction levels) write shims/drivers to go from other formats to our format.

See https://github.com/cosmos/interchain-security/tree/ph/875-use-traces-in-tests

Closing Criterion

It is possible to run the e2e tests using traces from files as inputs.
@p-offtermatt p-offtermatt mentioned this issue Aug 25, 2023
Closed
@p-offtermatt p-offtermatt self-assigned this Aug 25, 2023
@p-offtermatt p-offtermatt linked a pull request Aug 25, 2023 that will close this issue
chore: Implement JSON trace format (#878) #1243
Closed
@p-offtermatt p-offtermatt added the scope: testing Code review, testing, making sure the code is following the specification. label Aug 25, 2023
@p-offtermatt p-offtermatt changed the title Modify the e2e framework to take traces as an input (see https://github.com/cosmos/interchain-security/tree/ph/875-use-traces-in-tests) Modify the e2e framework to take traces as an input Aug 25, 2023
@p-offtermatt p-offtermatt added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 8, 2023
This was referenced Sep 15, 2023
Closed
Closed
This was linked to pull requests Sep 19, 2023
tests: Export struct fields in the e2e tests #1313
Merged
test: Add json marshal/unmarshal for test traces #1314
Merged
@p-offtermatt p-offtermatt reopened this Sep 20, 2023
@p-offtermatt
Copy link
Contributor Author

Reopening, since only part of this was merged so far

@p-offtermatt p-offtermatt linked a pull request Sep 25, 2023 that will close this issue
test: introduce flag for trace input to e2e framework #1318
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
1 participant
@p-offtermatt