Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Set Security: Add MsgOptIn & MsgOptOut #1586

Closed
Tracked by #853
insumity opened this issue Jan 23, 2024 · 0 comments · Fixed by #1620 or #1629
Closed
Tracked by #853

Partial Set Security: Add MsgOptIn & MsgOptOut #1586

insumity opened this issue Jan 23, 2024 · 0 comments · Fixed by #1620 or #1629
Assignees
Labels
C:x/provider Assigned automatically by the PR labeler S: NewThings Work towards your business objectives with new products, features, or integrations

Comments

@insumity
Copy link
Contributor

insumity commented Jan 23, 2024

Problem

Add the MsgOptIn and MsgOptOut messages that would be used for Partial Set Security (see ADR).

Closing criteria

  1. Investigate on whether we can read the votes of proposals to automatically opt in and if so implement this aspect as well (see Problem Details).
  2. State should be updated to keep track of all the validators that opted in (and when they opted in).
  3. State should be updated to remove validators when they opt out.
  4. Provide keeper methods as outlined in the ADR.
  5. Thoroughly test.

Problem details

It's not clear whether we can use the votes of a ConsumerAdditionProposal to automatically opt in a validator. This is because the Tally method deletes the votes after reading them. This also makes sense; There's no reason to keep the votes around after tallying them. Therefore, we wouldn't be able to extract any information on who voted Yes after a proposal has passed through GetVotes.

@insumity insumity added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Jan 23, 2024
@insumity insumity added C:x/provider Assigned automatically by the PR labeler S: NewThings Work towards your business objectives with new products, features, or integrations and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jan 23, 2024
@insumity insumity self-assigned this Jan 23, 2024
@MSalopek MSalopek linked a pull request Feb 7, 2024 that will close this issue
21 tasks
@insumity insumity closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler S: NewThings Work towards your business objectives with new products, features, or integrations
Projects
Status: ✅ Done
1 participant