Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Set Security: review the standalone to consumer changeover #1772

Closed
Tracked by #853
sainoe opened this issue Apr 8, 2024 · 1 comment
Closed
Tracked by #853

Partial Set Security: review the standalone to consumer changeover #1772

sainoe opened this issue Apr 8, 2024 · 1 comment
Assignees
Labels
scope: consumer Issues related to the consumer chain scope: docs Improvements or additions to documentation

Comments

@sainoe
Copy link
Contributor

sainoe commented Apr 8, 2024

The standalone to consumer changeover process was built under some assumptions that do not hold with PSS, and therefore needs to be reviewed.

@sainoe sainoe changed the title Review standalone changeover process Review the standalone to consumer changeover Apr 8, 2024
@sainoe sainoe self-assigned this Apr 8, 2024
@sainoe sainoe changed the title Review the standalone to consumer changeover Partial Set Security: review the standalone to consumer changeover Apr 8, 2024
@MSalopek MSalopek added scope: docs Improvements or additions to documentation scope: consumer Issues related to the consumer chain and removed needs-triage labels Jun 18, 2024
@insumity
Copy link
Contributor

Looked into the changeover logic and did not find anything that could be problematic in relations to PSS and standalone to consumer changeover logic. PSS did not change anything on the consumer-module side. Therefore, PSS could not have an impact on the changeover logic (e.g., ChangeOverToConsumer) that exists on the consumer module. The consumer chain would use the initial validator updates created from MakeConsumerGenesis and whether the consumer chain is standalone or not is irrelevant.
Lastly, I modified (locally) the E2E changeover test using TopN = 0 instead of TopN = 100 in the SubmitConsumerAdditionProposalAction, as well as passing a ValidatorSetCap to 2 and everything worked as expected.

@sainoe sainoe closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: consumer Issues related to the consumer chain scope: docs Improvements or additions to documentation
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants