Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more integration tests to consider multiple consumers #506

Closed
2 tasks done
Tracked by #678
shaspitz opened this issue Nov 21, 2022 · 3 comments
Closed
2 tasks done
Tracked by #678

Refactor more integration tests to consider multiple consumers #506

shaspitz opened this issue Nov 21, 2022 · 3 comments
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Nov 21, 2022

Problem

#475 is a good start to making our integration tests consider multiple consumers. But further work is needed.

Closing criteria

Build out and improve integration setup code, and integration tests themselves to consider multiple consumers. This issue can potentially be split into more granular ones if needed.

Problem details

Regarding integration setup:

  • Multi-consumer capable e2e tests #475 refactors CCVTestSuite.SetupTest(), and CCVTestSuite.SetupCCVChannel() to be functional for multiple consumers.
  • CCVTestSuite.SetupTransferChannel() and various other helpers still need to be refactored for multiple consumers

Regarding integration tests themselves:

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@shaspitz shaspitz added the scope: testing Code review, testing, making sure the code is following the specification. label Nov 21, 2022
@danwt
Copy link
Contributor

danwt commented Nov 30, 2022

Hey, can this be closed yet?

@shaspitz
Copy link
Contributor Author

shaspitz commented Nov 30, 2022

This issue is not solved yet, and pretty important imo. Most integration tests still consider only one consumer

@mpoke mpoke added this to the ICS v1.0.0 milestone Jan 17, 2023
@mpoke mpoke changed the title Refactor more e2e tests to consider multiple consumers EPIC: Refactor more e2e tests to consider multiple consumers Jan 18, 2023
@mpoke mpoke modified the milestones: ICS v1.0.0 , ICS v1.1.0 Jan 18, 2023
@mpoke mpoke added the admin: epic An EPIC -- meta issue used to track a body of work label Jan 24, 2023
@mpoke mpoke removed this from the ICS v1.1.0 milestone Mar 5, 2023
@mpoke mpoke changed the title EPIC: Refactor more e2e tests to consider multiple consumers EPIC: Refactor more integration tests to consider multiple consumers Jun 20, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 12, 2023
@mpoke mpoke changed the title EPIC: Refactor more integration tests to consider multiple consumers Refactor more integration tests to consider multiple consumers Sep 12, 2023
@mpoke mpoke removed the admin: epic An EPIC -- meta issue used to track a body of work label Sep 12, 2023
@MSalopek
Copy link
Contributor

Tests have multiple consumers and test key assignment features on one of the consumers.

Closing as completed. I cannot find the issue that solved this because there were many issues adding small changes + a large cosmos-sdk v47 refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants