Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate-wine-glass to use an output buffer #1

Merged
merged 1 commit into from Jan 16, 2018

Conversation

N6UDP
Copy link
Contributor

@N6UDP N6UDP commented Jan 13, 2018

This increases performance on my machine from about 2 minutes to 1.5 seconds as measured by measure-command.
https://github.com/dlwyatt/PowershellProfiler shows almost all the time was in the IO from Add-Content:

File                      Line HitCount PercentHitCount TotalMilliseconds PercentTime
----                     ---- -------- --------------- ----------------- -----------
generate-wine-glass.ps1  102     6480            3.13             39244       29.84
generate-wine-glass.ps1   99     6480            3.13             39044       29.69
generate-wine-glass.ps1  112     6240            3.02             37490       28.51

This increases performance on my machine from about 2 minutes to 1.5 seconds as measured by measure-command.  
https://github.com/dlwyatt/PowershellProfiler shows almost all the time was in the IO from Add-Content:
```
File         Line HitCount PercentHitCount TotalMilliseconds PercentTime
----         ---- -------- --------------- ----------------- -----------
generate-wine-glass.ps1  102     6480            3.13             39244       29.84
generate-wine-glass.ps1   99     6480            3.13             39044       29.69
generate-wine-glass.ps1  112     6240            3.02             37490       28.51
```
@cosmosdarwin cosmosdarwin merged commit 27a9ea3 into cosmosdarwin:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants