Amino Audit Outline #8
Conversation
Amino Audit Outline
…evs/stargate into cosmos-amino-audit-api-endpoints
There was a problem hiding this comment.
Seems super helpful but maybe would be good to get it into the SDK repo as a clearer summary of some aspects of the changelog? Probably worth a document in the SDK itself that summarizes what the Stargate upgrade was all about, how things changed, and specifics like this no how folks need to upgrade. In Tendermint repo we've had UPGRADING.md which serves this purpose beyond the changelog record of what changed. Maybe this could be the start of an UPGRADING.md for the SDK?
|
|
||
| The Legacy Amino interface provides an interface most similar to cosmoshub-2 and prior versions of the Cosmos SDK. This interface is available for both querying and sending transactions. It is implemented by executing Amino JSON serialization refliection over the new set of protobuf compatible structs. | ||
|
|
||
| The core finding of this audit is that while changes to the underlying structs result in an interface that is close to the prior version. |
| * **Endpoint Name:** QueryDelegatorDelegations | ||
| * **Endpoint Path:** ```"/staking/delegators/delegations"``` | ||
| * **What Changed:** | ||
| * ```“balance”``` now is no longer a number. It is a field with two values: ```"amount"``` and ```"Denom”``` |
There was a problem hiding this comment.
Should Denom be capitalized here? I believe JSON fields are all supposed to be lower case but there's been some inconsistency in the past
There was a problem hiding this comment.
That uppercase may have been a bug. I'll check on it.
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
AMINO Legacy REST endpoint audit.
Rendered:
https://github.com/cosmosdevs/stargate/blob/cosmos-amino-audit-api-endpoints/audit.md
To Do