Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal code review for x/liquidity - 1 #215

Closed
wants to merge 2 commits into from

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Feb 28, 2022

DO NOT MERGE THIS PR!!!

This PR is for internal code review and contains some suggestions and bug fixes.

  • WIP

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

x/liquidity/amm/orderbook.go Show resolved Hide resolved
x/liquidity/keeper/batch.go Show resolved Hide resolved
x/liquidity/keeper/pool.go Show resolved Hide resolved
x/liquidity/keeper/pool_test.go Show resolved Hide resolved
x/liquidity/keeper/swap.go Show resolved Hide resolved
x/liquidity/types/errors.go Show resolved Hide resolved
x/liquidity/types/util.go Show resolved Hide resolved
x/liquidity/types/pool_test.go Show resolved Hide resolved
x/liquidity/types/order.go Show resolved Hide resolved
@dongsam
Copy link
Contributor Author

dongsam commented Mar 18, 2022

Since everything has been resolved, we will proceed with the additional review in a separate PR.

@dongsam dongsam closed this Mar 18, 2022
@jaybxyz jaybxyz deleted the code-review/liquidity-1 branch October 27, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants