Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add skeleton for keeper test suite #23

Closed
wants to merge 4 commits into from

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Dec 30, 2021

Description

This PR contains some works from #18

Tasks

  • Add skeleton for keeper test suite
  • Add tx proto messages (DepositWithinBatch, WithdrawWithinBatch, SwapWithinBatch)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Dec 30, 2021
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Jan 10, 2022

Since we have lots of struct changes and there exists some conflicts with liquidity-poc branch, so I will just close this and rework based on the latest main branch.

@jaybxyz jaybxyz closed this Jan 10, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
fix: fix gas consumption issue for `ConditionTypeVote`
@jaybxyz jaybxyz deleted the kogisin/add-keeper branch October 27, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant