Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix simulation for the claim module #292

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Apr 12, 2022

Description

This PR fixes simulation logic for the claim module. It used to contain only failures.

closes: #291


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz marked this pull request as ready for review April 12, 2022 06:21
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam added this to the v2.0 milestone Apr 12, 2022
@jaybxyz jaybxyz merged commit 7fa5f2b into main Apr 18, 2022
@dongsam dongsam removed the c-sync label May 3, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
fix: fix simulation for the claim module #292 #304
@jaybxyz jaybxyz deleted the kogisin/291-fix-claim-sim branch October 27, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix simulation operation for claim module
3 participants