Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add mint pool address for mint module #316

Merged
merged 2 commits into from
May 31, 2022
Merged

feat!: add mint pool address for mint module #316

merged 2 commits into from
May 31, 2022

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented May 19, 2022 •
edited
Loading

Description

closes: #314

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam force-pushed the 314-separate-mint-pool-for-inflation branch from 628f5a0 to c851fc3 Compare May 19, 2022 11:45
@dongsam dongsam self-assigned this May 19, 2022
@dongsam dongsam force-pushed the 314-separate-mint-pool-for-inflation branch from c851fc3 to bf4478f Compare May 21, 2022 00:25
@dongsam dongsam marked this pull request as ready for review May 21, 2022 00:45
@crypin crypin mentioned this pull request May 23, 2022
Merged
9 tasks
jaybxyz
jaybxyz approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hallazzang
hallazzang requested changes May 29, 2022
View reviewed changes
proto/squad/mint/v1beta1/mint.proto Outdated Show resolved Hide resolved
hallazzang
hallazzang requested changes May 29, 2022
View reviewed changes
x/mint/spec/04_params.md Outdated Show resolved Hide resolved
@dongsam dongsam requested a review from hallazzang May 30, 2022 01:55
hallazzang
hallazzang approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit 6377661 into main May 31, 2022
@dongsam dongsam removed the c-sync label Jul 4, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
@crypin
Merge pull request #35 from crescent-network/cherry-pick/316
1732fec 
feat!: add mint pool address for mint module #316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallazzang hallazzang hallazzang approved these changes

@jaybxyz jaybxyz jaybxyz approved these changes

Assignees

@dongsam dongsam

Labels
x/mint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MintPoolAddress on mint params to separate inflation with tx fee
3 participants
@dongsam @hallazzang @jaybxyz