feat: improve PoolResponse from gGRPC queries #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-sync
x/liquidity
documentation
dongsam
approved these changes
Jul 12, 2022
- add `base_coin` and `quote_coin` fields under `balances` - add `price` field which is `null` for disabled pools - add `pool_coin_supply` field
hallazzang
force-pushed
the
improve-pool-response
branch
from
a6735f8
to
454165f
Compare
|
I've rebased and force-pushed commits for easier commit tracking. I'm sorry about force-pushing after code review @dongsam. |
10 tasks
dongsam
pushed a commit
that referenced
this pull request
Aug 31, 2022
feat: improve PoolResponse from gGRPC queries #335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves
PoolResponsewhich is returned from pool query endpoints.Tasks
base_coinandquote_coinfields underbalancespricefield which isnullfor disabled poolspool_coin_supplyfield