Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: calculation bug of liquidstaking voting_power #346

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: calculation bug of liquidstaking voting_power #346

merged 2 commits into from
Aug 19, 2022

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Aug 11, 2022

Description

Fixed a bug that missed the calculation of the voting power of the pool coin that was not in the user's balance when calculating the liquid stacking voting power at SetLiquidStakingVotingPowers

Fixed to create a bTokenSharePerPoolCoinMap for all pool coins before calculating the voting power for user's farming positions

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam marked this pull request as ready for review August 11, 2022 14:14
hallazzang
hallazzang requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

CHANGELOG.md Outdated Show resolved Hide resolved
x/liquidstaking/keeper/tally.go Outdated Show resolved Hide resolved
jaybxyz
jaybxyz approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit aaff5f1 into main Aug 19, 2022
@crypin crypin mentioned this pull request Aug 19, 2022
Merged
9 tasks
@dongsam dongsam removed the c-sync label Aug 25, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
@crypin
Merge pull request #53 from crescent-network/cherry-pick/346
cb7c8b2 
fix: calculation bug of liquidstaking voting_power #346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallazzang hallazzang hallazzang approved these changes

@jaybxyz jaybxyz jaybxyz approved these changes

Assignees
No one assigned
Labels
x/liquidstaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dongsam @hallazzang @jaybxyz