Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in AllocateRewards and add submit-proposal cmd #369

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

hallazzang
Copy link
Contributor

Description

This PR fixes some bugs in AllocateRewards and register missing proposal tx cmd for FarmingPlanPropsoal.

Tasks

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

x/farm/client/cli/tx.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2022
@hallazzang hallazzang marked this pull request as ready for review October 6, 2022 13:45
docs/cli/farm.md Outdated Show resolved Hide resolved
docs/cli/farm.md Outdated Show resolved Hide resolved
docs/cli/farm.md Outdated Show resolved Hide resolved
docs/cli/farm.md Outdated Show resolved Hide resolved
docs/api/farm.md Outdated Show resolved Hide resolved
@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 6, 2022

I don't understand why it decreases coverage as I see change actually increases if you go to the link below.
https://app.codecov.io/gh/cosmosquad-labs/squad/pull/369

- change account addresses in docs
- add missing backslashes
- add more descriptions to docs and tx command
@hallazzang
Copy link
Contributor Author

I don't understand why it decreases coverage as I see change actually increases if you go to the link below. https://app.codecov.io/gh/cosmosquad-labs/squad/pull/369

Yes, that's weird. Let's just ignore that result now.

@jaybxyz jaybxyz self-requested a review October 6, 2022 15:18
@hallazzang hallazzang merged commit 884b6e0 into main Oct 6, 2022
@hallazzang hallazzang removed the c-sync label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation x/farm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants