Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump SDK to v0.45.9 and remove its own ics23 package and use c… #377

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 17, 2022

Description

This PR bumps Cosmos SDK from v0.45.3 to v0.45.9.

Tasks

  • Bump Cosmos SDK from v0.45.3 to v0.45.9
  • Remove its own ics23 package
  • Update replace directive to use ../cosmos-sdk/ics23/go v0.8.0
  • Bump go version to v1.18 as SDK v0.45.9 uses go version 1.18
  • Change all the places that document v0.45.3
  • Upgrade go version to 1.18 in github workflow actions
  • Fix to use go install instead of go get since we use go v1.18

References

https://github.com/cosmos/gaia/tree/v7.1.0


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 17, 2022
@jaybxyz jaybxyz changed the title chore: bump SDk to v0.45.9 and remove its own ics23 package and use c… chore: bump SDK to v0.45.9 and remove its own ics23 package and use c… Oct 17, 2022
@jaybxyz jaybxyz marked this pull request as ready for review October 17, 2022 12:46
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz jaybxyz merged commit 043c8f9 into release/v2.2.x Oct 17, 2022
jaybxyz added a commit that referenced this pull request Oct 18, 2022
#377)

* chore: bump SDk to v0.45.9 and remove its own ics23 package and use cosmos-sdk ics23

* build: bump go version to 1.18

* chore: update version and upgrade go version in workflow actions

* build: use new SDK version that is based v0.45.9

* fix: add validation check on match

* build: use module golangci-lint and resolve lint issues

* fix: use go install instead of go get

(cherry picked from commit 043c8f9)
@jaybxyz jaybxyz mentioned this pull request Oct 18, 2022
12 tasks
@jaybxyz jaybxyz removed the c-sync label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants