Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix simulation parameters range #382

Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix: fix simulation parameters range #382

merged 2 commits into from
Oct 21, 2022

Conversation

hallazzang
Copy link
Contributor

Description

This PR changes x/liquidity simulation parameters range since too low tick precision and max price limit ratio could make the simulation to fail

Tasks

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

too low tick precision and max price limit ratio could make the simulation to fail
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this offline. LGTM!

@hallazzang hallazzang merged commit 861d7e9 into main Oct 21, 2022
@hallazzang hallazzang removed the c-sync label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants