Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constant mint module #39

Merged
merged 7 commits into from
Jan 24, 2022
Merged

feat: add constant mint module #39

merged 7 commits into from
Jan 24, 2022

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Jan 12, 2022

Description

closes: #29

Tasks

  • [ ]

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam marked this pull request as ready for review January 23, 2022 19:20
jaybxyz
jaybxyz suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments and suggestions; mostly around naming consistency and code refactoring to improve readability and intuitiveness. It is okay to handle them once we move over to squad-sdk.

proto/crescent/mint/v1beta1/mint.proto Show resolved Hide resolved
app/app.go Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/mint/client/cli/query.go Outdated Show resolved Hide resolved
x/mint/client/cli/query.go Outdated Show resolved Hide resolved
x/mint/keeper/keeper.go Show resolved Hide resolved
x/mint/spec/03_begin_block.md

# Begin-Block

- BlockInflation = `InflationAmountThisPeriod * min(CurrentBlockTime-LastBlockTime,10second)/(InflationPeriodEndDate-InflationPeriodStartDate)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the calculation for blockInflation parameter in BeginBlocker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is.

@dongsam dongsam requested a review from jaybxyz January 24, 2022 04:41
@dongsam dongsam merged commit ca54f87 into main Jan 24, 2022
@hallazzang hallazzang deleted the 29-constant-mint-module branch February 28, 2022 06:51
dongsam pushed a commit that referenced this pull request Aug 31, 2022
@crypin
Merge pull request #39 from crescent-network/cherry-pick/323
4260515 
fix: bug in order book and pool orders calculation #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallazzang hallazzang Awaiting requested review from hallazzang hallazzang is a code owner

@jaybxyz jaybxyz Awaiting requested review from jaybxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom mint module for constant inflation
2 participants
@dongsam @jaybxyz