Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APIS-340] Add comparison of Tx 'value' and estimated fee to balance in EVM sign page #349

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[APIS-340] Add comparison of Tx 'value' and estimated fee to balance in EVM sign page #349

merged 2 commits into from
Jun 26, 2024

Conversation

G-Gamja
Copy link
Member

@G-Gamja G-Gamja commented Jun 11, 2024

  • tx의 타입이 simpleSend가 아닌 경우에도 tx의 value값이 fee 지불 가능성 체크 로직에 합산될 수 있도록 로직을 수정했습니다.
    • 인앱 Squid EVM 스왑 시 실제 사용되는 코인의 수량(cross chain fee)을 확인할 수 있게 되었습니다.
  • 변수명을 가독성이 있도록 수정했습니다.
    • displayValue -> displayFeeValue
    • totalDisplayAmount -> totalPayableNativeCoinDisplayAmount
    • totalBaseAmount -> totalPayableNativeCoinBaseAmount

@G-Gamja
perf((evm-transaction)): check 'value' with balance in evm Transactio…
01977e4 
…n page

- 일반 샌드 tx일때만 예상 fee 어마운트에 합산해 예산과 비교했던 로직에서 tx의 value값을 합산하여 계산하도록 수정함
@G-Gamja G-Gamja self-assigned this Jun 11, 2024
@G-Gamja G-Gamja marked this pull request as ready for review June 11, 2024 04:55
@G-Gamja G-Gamja requested a review from ong-ar as a code owner June 11, 2024 04:55
@G-Gamja
feat((util)): Add hexOrDecimalToDecimal & rename vars
33f881f 
- 파람을 16,10진수의 값을 받아 10진수의 값을 반환하는 유틸 함수 추가
- 변수 명 변경
  - payable native coin -> native coin transfer의 맥락으로 변경
ong-ar
ong-ar approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@ong-ar ong-ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@ong-ar ong-ar merged commit 6cb3c8e into develop Jun 26, 2024
@ong-ar ong-ar deleted the feature/APIS-340-check-eth-value branch June 26, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ong-ar ong-ar ong-ar approved these changes

Assignees

@G-Gamja G-Gamja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G-Gamja @ong-ar