Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIS-131] Add sui sign message and sign transaction block #350

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

G-Gamja
Copy link
Member

@G-Gamja G-Gamja commented Jun 17, 2024

sui signMessage, signTransactionBlock api추가 및 sui dapp-kit에서 익스텐션이 선택될 수 있도록 코드를 수정했습니다.

  • api 추가
    • sui:signMessage, sui:signTransactionBlock (렛저 사인 포함)
  • dapp-kit 지갑 연결 오류 수정 (connect메서드 리스폰스 수정) ]
  • sui sdk 버젼 업그레이드
    • SuiObject 타입 변화에 따른 null 처리 작업 추가

스크린샷 2024-06-17 오전 11 26 49

- 디폴트 노드 버젼 변경 (v. 20)
- 필요 노드 버젼 변경 (20 -> 16)
- sui dapp-kit 연결 오류 해결
  - connect 함수 수정
- sign message함수를 위해 sdk버젼업
@G-Gamja G-Gamja self-assigned this Jun 17, 2024
@G-Gamja G-Gamja marked this pull request as ready for review June 17, 2024 02:31
@G-Gamja G-Gamja requested a review from ong-ar as a code owner June 17, 2024 02:31
@G-Gamja G-Gamja marked this pull request as draft June 17, 2024 05:31
@G-Gamja G-Gamja marked this pull request as ready for review June 19, 2024 07:35
Copy link
Member

@ong-ar ong-ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@G-Gamja
Copy link
Member Author

G-Gamja commented Jul 12, 2024

해당 작업은 [APIS-335 Migrate sui sdk(support 2.0 api)](https://github.com/cosmostation/cosmostation-chrome-extension/pull/359)의 하위 작업으입니다. QA는 [API-335]로 진행하려고 합니다.

노드 버젼 업그레이드에 따른 사이드 이펙트가 없는지 확인 후 다시 QA 요청드리려고 합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants