-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APIS-131] Add sui sign message and sign transaction block #350
Open
G-Gamja
wants to merge
12
commits into
develop
Choose a base branch
from
feature/APIS-131-add-sui-sign_message-and-sign_transaction_block
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[APIS-131] Add sui sign message and sign transaction block #350
G-Gamja
wants to merge
12
commits into
develop
from
feature/APIS-131-add-sui-sign_message-and-sign_transaction_block
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 디폴트 노드 버젼 변경 (v. 20)
- 필요 노드 버젼 변경 (20 -> 16) - sui dapp-kit 연결 오류 해결 - connect 함수 수정
- sign message함수를 위해 sdk버젼업
- Define Sui and MetaMask types in window.d.ts - fix sui explorer url path (Unexpected character included)
- substitute deprecated api
ong-ar
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
노드 버젼 업그레이드에 따른 사이드 이펙트가 없는지 확인 후 다시 QA 요청드리려고 합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sui signMessage, signTransactionBlock api추가 및 sui dapp-kit에서 익스텐션이 선택될 수 있도록 코드를 수정했습니다.