Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for incorrect values in settings #11

Closed
sharkmu opened this issue Dec 29, 2023 · 1 comment
Closed

Better error handling for incorrect values in settings #11

sharkmu opened this issue Dec 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working properly

Comments

@sharkmu
Copy link
Contributor

sharkmu commented Dec 29, 2023

If you add a value in the settings which is greater than 0, but not a round number, then it'll still accept it.
The problem with it is that it isn't possible to add 1.5 gap or some sort.

My fix for this problem is to check the values not just to be greater than 0, but also for it to be a round number. Although a second solution could be to round up those numbers.

Let me know which solution is the better.

Note: I'd like to work on this Issue, if possible

@ghost
Copy link

ghost commented Dec 29, 2023

I think it's better to show a warning message. It'd be less confusing.

@ghost ghost added the bug Something isn't working properly label Dec 29, 2023
@ghost ghost assigned sharkmu Dec 29, 2023
ghost pushed a commit that referenced this issue Dec 29, 2023
Improve error handling for not a round number in settings. Issue: #11
@sharkmu sharkmu closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

No branches or pull requests

1 participant