Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix cannot ctrl c when configed kill delay #287

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

xiantang
Copy link
Collaborator

@xiantang xiantang commented Jun 3, 2022

close #278

@xiantang xiantang changed the title try to fix cannot ctrl c try to fix cannot ctrl c when configed kill delay Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #287 (ad84b26) into master (bc71f7d) will increase coverage by 1.11%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   56.79%   57.90%   +1.11%     
==========================================
  Files           6        6              
  Lines         854      860       +6     
==========================================
+ Hits          485      498      +13     
+ Misses        313      306       -7     
  Partials       56       56              
Impacted Files Coverage Δ
runner/engine.go 50.65% <71.42%> (+1.05%) ⬆️
runner/util_darwin.go 66.66% <100.00%> (+8.33%) ⬆️
runner/util_linux.go 83.33% <100.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc71f7d...ad84b26. Read the comment docs.

@xiantang xiantang merged commit 65bd047 into master Jun 3, 2022
d-bytebase added a commit to bytebase/air that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't stop Air with Ctrl-C
1 participant