Worn if tmp is dot #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2020 10:45
|
Are PR's actually accepted or responded with, here? |
|
Looks like they don't accept for a while |
|
i think use warning is a not better way. because you also warning this message and user know this problem they use ctrl + c to stop the process and his project Always will be clean. as I think you should raise a err and stop the project! |
|
pr is welcome! |
|
I agree with @xiantang. Data loss should not be acceptable at all. Instead of a warning, the best option is to print an error message and exit the application immediately, without triggering the cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added warning log with red default color