fix #662: 使用方向键翻页 #1118
Merged
fix #662: 使用方向键翻页 #1118
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
requested changes
Nov 13, 2023
| @@ -4,6 +4,7 @@ | |||
| <script async src="//yihui.name/js/no-highlight.js"></script> | |||
| <script async src="{{ relURL "/js/pangu.js" }}"></script> | |||
| <script src="https://cdn.jsdelivr.net/npm/@xiee/utils/js/heading-anchor.min.js" defer></script> | |||
| <script async src="{{ relURL "/js/shortcuts.js" }}"></script> | |||
There was a problem hiding this comment.
Suggested change
| <script async src="{{ relURL "/js/shortcuts.js" }}"></script> | |
| <script src="https://cdn.jsdelivr.net/npm/@xiee/utils/js/post-nav.min.js" defer></script> |
There was a problem hiding this comment.
我这个比你的功能多一些。除了文章翻页，首页也能翻页，还添加了提示框。没提示框估计读者也不知道能翻页。
There was a problem hiding this comment.
好的，我抽空看一下。如果能整合到一个脚本中就好了，别人可以复用。谢谢。
There was a problem hiding this comment.
可是不同 Hugo 主题里面那些元素的类名不一样，咋复用？
There was a problem hiding this comment.
@yihui 我已经把你代码抄得差不多了，应该没问题了。
就是这段没看明白在干啥。
CyrusYip
commented
Nov 17, 2023
Comment on lines
+53
to
+57
| // make <pre> focusable | ||
| const preElements = document.querySelectorAll("pre"); | ||
| preElements.forEach((element) => { | ||
| element.setAttribute("tabindex", "0"); | ||
| }); |
There was a problem hiding this comment.
tabindex 应该加到主题，此处代码只是临时使用。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决 #662