Consider linking OpenSSL as dynamic framework in PodSpec

[vixentael]

Continue of issue #127.

Let's move from compiled OpenSSl as static lib to dynamic framework.

See comments
#127 (comment)
#127 (comment)

[vixentael]

See branch dynamic frameworks for latest changes.

Current state:

Example projects working fine.

Linting fails with errors:

pod spec lint themis.podspec --subspec=themis --verbose --allow-warnings --fail-fast

    - ERROR | [iOS] [themis] xcodebuild: Returned an unsuccessful exit code.
    - ERROR | [themis] xcodebuild:  /var/folders/1v/7l7m798s24g1xqrh1kdxb2mr0000gn/T/CocoaPods/Lint/App/main.m:1:1: error: use of '@import' when modules are disabled
    - ERROR | [themis] xcodebuild:  /var/folders/1v/7l7m798s24g1xqrh1kdxb2mr0000gn/T/CocoaPods/Lint/App/main.m:2:1: error: use of '@import' when modules are disabled
    - ERROR | [themis] xcodebuild:  /var/folders/1v/7l7m798s24g1xqrh1kdxb2mr0000gn/T/CocoaPods/Lint/App/main.m:3:1: error: use of '@import' when modules are disabled

[gene-eu-zz]

are there any changes in the ecosystem we'd like to wait until we make final decision? 0.9.4 is coming at steady pace, need to decide whether there are actionable points here

[vixentael]

I'll check the current state of CocoaPods infrastructure and let you know. I don't think that we need to wait, anyway.

[vixentael]

That's still an issue.
0.9.4 podspec links OpenSSl as static library.

[vixentael]

Status update.

I've updated branch podspec_dynamic_frameworks, merged from master.

Current state: can't make CocoaPods linting working successfully due to error mentioned above error: use of '@import' when modules are disabled.

Other ways to create dynamic frameworks:

• http://mrdekk.ru/2016/04/30/cocoapods-static-transitive-binary-dependencies/
• https://github.com/x2on/OpenSSL-for-iPhone/blob/master/create-openssl-framework.sh

Maintainers with similar problems:

• Let users specify use_frameworks! in their Podfile grpc/grpc#4121 (comment)
• Support dynamic frameworks grpc/grpc#6849
• use_frameworks! results in pod not finding headers of its dependencies CocoaPods/CocoaPods#4605

Using BoringSSL instead:

• Use BoringSSL instead of OpenSSL grpc/grpc#4235
• https://github.com/cristianbica/boringssl-podspec/blob/master/BoringSSL.podspec

Next steps:

Play a bit more with creating dynamic frameworks (ideally, podspec should not disable CLANG MODULES ('CLANG_ENABLE_MODULES' => 'NO'))

Try to switch to BoringSSL

[vixentael]

Woohoo, I think we can solve this issue when this PR will be merged:

https://github.com/levigroker/GRKOpenSSLFramework/pull/2

Status update:

1. I changed Themis.podspec dependency to GRKOpenSSLFramework (OpenSSL static libs wrapped into dynamic frameworks).

2. Xcode building problems solved by adding #ifdef __OBJC__ ... #endif lines into openssl.h file inside framework. In this case project is built successfully, no need to disable CLANG modules.

3. Podspec looks like this (GRKOpenSSLFramework version might be .3 after merging PR) --> https://raw.githubusercontent.com/cossacklabs/themis/podspec_dynamic_frameworks_GRKOpenSSLFramework/themis.podspec

4. Podspec passes pod spec lint validation successfully.

5. Latest changes are pushed to podspec_dynamic_frameworks_GRKOpenSSLFramework branch.

Next steps:

• wait until PR is merged
• update podspec to link to the updated GRKOpenSSLFramework version
• make sure that all example projects are building successfully
• merge changes to release_0.9.5 branch
• enjoy

[vixentael]

I think it's solved now!