Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom href links #37

Closed
anantoghosh opened this issue Apr 11, 2019 · 3 comments
Closed

Support for custom href links #37

anantoghosh opened this issue Apr 11, 2019 · 3 comments

Comments

@anantoghosh
Copy link

I was trying to add a "click to whatsapp chat" on my page which is a regular href link with the user's phone number.
https://wa.me/phonenumber
https://faq.whatsapp.com/en/android/26000030/

Some other apps, such as skype use href="skype:..". Would it be possible for the user to specify a custom url and protocol so react-obfuscate could virtually support any url?

@coston
Copy link
Owner

coston commented Apr 11, 2019

Hi @anantoghosh! Thank you for opening this issue. It makes a lot of sense to have this functionality. I added the href prop as a catch-all url prop. Please let me know what you think about the changes at: #38.

You can npm i react-obfuscate@next to test.
The branch demonstrates usage of the href prop at: https://deploy-preview-38--react-obfuscate.netlify.com/

@anantoghosh
Copy link
Author

@coston Incredible Work 🥇!. It's working fine 👍.

Thank you very much for your work.

coston added a commit that referenced this issue Apr 11, 2019
@coston coston closed this as completed Apr 11, 2019
@coston
Copy link
Owner

coston commented Apr 11, 2019

@anantoghosh Thanks again! The latest update is at npm i react-obfuscate@3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants