Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include docs and tests in MANIFEST.in #2

Merged
merged 2 commits into from
Jul 13, 2017
Merged

include docs and tests in MANIFEST.in #2

merged 2 commits into from
Jul 13, 2017

Conversation

KireinaHoro
Copy link
Contributor

The PyPI source tarballs don't have tests and docs included by now, which IMO isn't a good practice.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e7f5e62 on KireinaHoro:manifest-pr into d3382d5 on cosven:master.

cosven
cosven reviewed Jul 13, 2017
View reviewed changes
MANIFEST.in Outdated
@@ -0,0 +1,7 @@
recursive-include tests *
recursive-include docs *
recursive-include tests *.pyc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for pyc and pyo files ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. updated.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling dc879e1 on KireinaHoro:manifest-pr into d3382d5 on cosven:master.

@cosven cosven merged commit 2dc3c45 into cosven:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosven cosven cosven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KireinaHoro @coveralls @cosven