This repository has been archived by the owner on Jun 30, 2019. It is now read-only.
add xiami provider #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosven
commented
Aug 17, 2018
fuocore/xiami/api.py
Outdated
| } | ||
| payload = self.encrypt_request(data) | ||
| res_data = self.request("GET", action, payload) | ||
| if res_data is None: |
There was a problem hiding this comment.
最好不要自动刷新 cookie，在上层来完成这个操作。
现在这样写有几个问题：
- 重复代码：每次请求都有可能出现 cookies 过期的情况，也就是每个函数都需要写这么一段逻辑
- 多个请求容易出现未知情况，不利于排查问题，一般来说，尽量避免
- 底层应该尽量简单，只完成自己的功能，上层来处理复杂的逻辑
fuocore/xiami/api.py
Outdated
| } | ||
| payload = self.encrypt_request(data) | ||
| res_data = self.request("GET", action, payload) | ||
| if res_data is None: |
fuocore/xiami/api.py
Outdated
| } | ||
| payload = self.encrypt_request(data) | ||
| res_data = self.request("GET", action, payload) | ||
| if res_data is None: |
fuocore/xiami/api.py
Outdated
| data = {'songId': song_id} | ||
| payload = self.encrypt_request(data) | ||
| res_data = self.request("GET", action, payload) | ||
| if res_data is None: |
fuocore/xiami/api.py
Outdated
| songs = [] | ||
| try: | ||
| # FIXME: 这里写个 for 循环应该有点问题 | ||
| for start in range(0, len(song_ids), 200): |
There was a problem hiding this comment.
这里在 for 循环中发送 web 请求，很容易出问题：比如 IP 被禁、一个请求出错，整个就失败了
fuocore/xiami/api.py
Outdated
| logger.error(str(e)) | ||
| return None | ||
|
|
||
| def album_comments(self, album_id): |
fuocore/xiami/api.py
Outdated
| } | ||
| payload = self.encrypt_request(data) | ||
| res_data = self.request("GET", action, payload) | ||
| if res_data is None: |
fuocore/xiami/api.py
Outdated
| logger.error(str(e)) | ||
| return [], None | ||
|
|
||
| def artist_comments(self, artist_id): |
fuocore/xiami/api.py
Outdated
| return [] | ||
|
|
||
| # 相似歌曲 相似歌单 相似歌手 | ||
| def similar_songs(self, song_id): |
fuocore/xiami/api.py
Outdated
| return [] | ||
|
|
||
| # 创建歌单 更新歌单名称 删除歌单 | ||
| def new_playlist(self, name='default'): |
There was a problem hiding this comment.
TODO: playlist 的一些更新操作暂时不加
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by @cyliuu