Skip to content

Commit

Permalink
Fix a critical bug on CotEditor 3.1.0 + macOS 10.12.1 (#640)
Browse files Browse the repository at this point in the history
  • Loading branch information
1024jp committed Nov 17, 2016
1 parent 8d11ee1 commit df5465f
Show file tree
Hide file tree
Showing 10 changed files with 53 additions and 10 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
Change Log
==========================

develop
--------------------------

### Fixes

- Fix a critical issue on CotEditor 3.1.0 where documents can't be opened under some specific environments.



3.1.0 (172)
--------------------------

Expand Down
4 changes: 2 additions & 2 deletions CotEditor/CotEditor -AppStore-Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -945,11 +945,11 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>3.1.0</string>
<string>3.1.1-alpha</string>
<key>CFBundleSignature</key>
<string>cEd1</string>
<key>CFBundleVersion</key>
<string>172</string>
<string>173</string>
<key>LSApplicationCategoryType</key>
<string>public.app-category.productivity</string>
<key>LSMinimumSystemVersion</key>
Expand Down
4 changes: 2 additions & 2 deletions CotEditor/CotEditor-Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -945,11 +945,11 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>3.1.0</string>
<string>3.1.1-alpha</string>
<key>CFBundleSignature</key>
<string>cEd1</string>
<key>CFBundleVersion</key>
<string>172</string>
<string>173</string>
<key>LSApplicationCategoryType</key>
<string>public.app-category.productivity</string>
<key>LSMinimumSystemVersion</key>
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,28 @@ <h1>Release Notes</h1>

<article>
<header>
<h1>CotEditor 3.1.0</h1>
<h1>CotEditor 3.1.1</h1>
<p>release: <time>2016-11</time></p>
</header>


<section>
<h3>Fixes</h3>

<ul>
<li>Fix a critical issue on CotEditor 3.1.0 where documents can't be opened under some specific environments.</li>
</ul>
</section>
</article>


<article>
<header>
<h1>CotEditor 3.1.0</h1>
<p>release: <time>2016-11-17</time></p>
</header>


<section>
<h3>New Features</h3>

Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,28 @@ <h1>リリースノート</h1>

<article>
<header>
<h1>CotEditor 3.1.0</h1>
<h1>CotEditor 3.1.1</h1>
<p>リリース: <time>2016-11</time></p>
</header>


<section>
<h2>修正</h2>

<ul>
<li>特定の環境下で、CotEditor 3.1.0 で書類が開けないクリティカルな不具合を修正</li>
</ul>
</section>
</article>


<article>
<header>
<h1>CotEditor 3.1.0</h1>
<p>リリース: <time>2016-11-17</time></p>
</header>


<section>
<h2>新機能</h2>

Expand Down
2 changes: 1 addition & 1 deletion CotEditor/Sources/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
NSApp.servicesProvider = ServicesProvider()

// setup touchbar
if #available(macOS 10.12.1, *) {
if #available(macOS 10.12.1, *), NSClassFromString("NSTouchBar") != nil {
NSApp.isAutomaticCustomizeTouchBarMenuItemEnabled = true
}

Expand Down
4 changes: 2 additions & 2 deletions CotEditor/Sources/DocumentViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ final class DocumentViewController: NSSplitViewController, SyntaxStyleDelegate,
viewController.textView?.wrapsLines = wrapsLines
}

if #available(OSX 10.12.1, *) {
if #available(macOS 10.12.1, *), NSClassFromString("NSTouchBar") != nil {
self.validateTouchBarItem(identifier: .wrapLines)
}
}
Expand All @@ -464,7 +464,7 @@ final class DocumentViewController: NSSplitViewController, SyntaxStyleDelegate,
viewController.textView?.showsInvisibles = showsInvisibles
}

if #available(OSX 10.12.1, *) {
if #available(macOS 10.12.1, *), NSClassFromString("NSTouchBar") != nil {
self.validateTouchBarItem(identifier: .invisibles)
}
}
Expand Down
2 changes: 1 addition & 1 deletion CotEditor/Sources/EditorTextViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ final class EditorTextViewController: NSViewController, NSTextViewDelegate {
textView.blockCommentDelimiters = syntaxStyle?.blockCommentDelimiters
textView.firstSyntaxCompletionCharacterSet = syntaxStyle?.firstCompletionCharacterSet

if #available(OSX 10.12.1, *) {
if #available(macOS 10.12.1, *), NSClassFromString("NSTouchBar") != nil {
textView.validateTouchBarItem(identifier: .comment)
}
}
Expand Down

0 comments on commit df5465f

Please sign in to comment.