Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strikethrough not highlighting on markdown #1651

Closed
cal-ellevation opened this issue Jun 8, 2024 · 2 comments
Closed

Strikethrough not highlighting on markdown #1651

cal-ellevation opened this issue Jun 8, 2024 · 2 comments
Assignees
Labels
bug somethings work not correctly syntax highlight issues related to syntax highlighting
Milestone

Comments

@cal-ellevation
Copy link

Description

Highlighting not working for strikethrough when doing something like "this should be striked out". Highlighting is as if it is all just text.

To Reproduce

Type text into editor with ~~ surrounding text and see that it isn't striked out.

Expected behavior

Text would have some way to show that it should be striked out.

CotEditor version

4.8.5

macOS version

Sonoma 14.5

Additional context

No response

@cal-ellevation cal-ellevation added the potential bug issues not yet tested label Jun 8, 2024
@1024jp 1024jp self-assigned this Jun 9, 2024
@1024jp 1024jp added bug somethings work not correctly syntax highlight issues related to syntax highlighting and removed potential bug issues not yet tested labels Jun 9, 2024
@1024jp 1024jp added this to the 4.8.6 milestone Jun 9, 2024
@1024jp 1024jp closed this as completed in 1955530 Jun 9, 2024
@1024jp
Copy link
Member

1024jp commented Jun 9, 2024

Oops it is a kind of bugs that the current Markdown syntax doesn't highlight (= colorize) strikethrough.
I've just fixed it so that the fix will be shipped with the next version, CotEditor 4.8.6.
Thank you for pointing it out.

But CotEditor never actually draw strikethrough line for strikethrough markup in Markdown syntax.
CotEditor is a general text editor. It colorize keywords, or specific patterns of text, but not style it as Markdown says.

@cal-ellevation
Copy link
Author

cal-ellevation commented Jun 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug somethings work not correctly syntax highlight issues related to syntax highlighting
Development

No branches or pull requests

2 participants