Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to define custom metadata #1015

Merged
merged 1 commit into from
May 3, 2023

Conversation

v4vong
Copy link
Contributor

@v4vong v4vong commented May 1, 2023

Description

This new feature allows users to define custom metadata in the <head> without overriding the whole head.html. They just need to put their metadata into custom-head.html, then the metadata would be automatically included into the <head>.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Additional context

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • I have tested this feature in the browser

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to rename custom-head.html to metadata-hook.html.

_includes/custom-head.html Outdated Show resolved Hide resolved
@cotes2020 cotes2020 merged commit ad2a7e3 into cotes2020:master May 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants