-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(build): use jekyll-include-cache
plugin to reduce build time
#1098
Conversation
Hi @jakerr, the include of the dynamic file is removed in this PR, what do you think? |
d08ba0a
to
ba9099b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you!
I just found the one case where the template needs dynamic page info (the sidebar) I checked all of the other templates and they look good to cache to me.
Here's the perf for this change checked locally (on this site it was 4 minutes without this change):
Build Process Summary:
| PHASE | TIME |
+----------+--------+
| RESET | 0.0001 |
| READ | 2.0448 |
| GENERATE | 0.0375 |
| RENDER | 9.8069 |
| CLEANUP | 0.0042 |
| WRITE | 0.1675 |
Site Render Stats:
| Filename | Count | Bytes | Time |
+--------------------------------------------------------------------+-------+------------+-------+
| _layouts/page.html | 1168 | 122040.89K | 6.781 |
| jekyll-theme-chirpy-6.0.1/_includes/related-posts.html | 326 | 3514.48K | 6.367 |
| _layouts/default.html | 1168 | 248613.28K | 1.806 |
| _includes/head.html | 1168 | 5208.82K | 0.810 |
| jekyll-theme-chirpy-6.0.1/_includes/js-selector.html | 1168 | 854.92K | 0.300 |
| jekyll-theme-chirpy-6.0.1/_includes/sidebar.html | 1168 | 2961.32K | 0.299 |
Oh one more thing. How are you enabling the plugin? Is it automatic?
|
For the source code project here, the plugin is referenced in the
For users who use the gem package, currently until the new Chirpy gem is released, the |
Resolve #1094 and add margin bottom for layout tags Co-authored-by: Jake Kerr <kodafox@gmail.com>
ba9099b
to
42f4760
Compare
Ah thanks. I wasn't aware of the difference between depending on _plugins in a Jekyll site and depending on them from normal libs when writing plugins. Found a bit of info on that here. This PR looks good to me. |
In fact, there is no need to modify |
…otes2020#1098) Resolve cotes2020#1094 and add margin bottom for layout tags Co-authored-by: Jake Kerr <kodafox@gmail.com>
PR: cotes2020/jekyll-theme-chirpy#1098 Once this code is available in the latest gem we can remove our overrides
PR: cotes2020/jekyll-theme-chirpy#1098 Once this code is available in the latest gem we can remove our overrides
PR: cotes2020/jekyll-theme-chirpy#1098 Once this code is available in the latest gem we can remove our overrides
Description
Resolves #1094
Type of change
Additional context
Improvements to:
jekyll-include-cache
plugin to reduce build time #1097How has this been tested
bash ./tools/test
(at the root of the project) locally and passed