Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in feed.xml #965

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Fix a bug in feed.xml #965

merged 4 commits into from
Apr 10, 2023

Conversation

v4vong
Copy link
Contributor

@v4vong v4vong commented Apr 5, 2023

Description

It might cause a syntax error if the post.title contains double quotes. One of the solutions is using the escape filter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system:
  • Ruby version:
  • Bundler version:
  • Jekyll version:

assets/feed.xml Outdated Show resolved Hide resolved
v4vong and others added 3 commits April 10, 2023 11:09
Co-authored-by: Cotes <11371340+cotes2020@users.noreply.github.com>
Co-authored-by: Cotes <11371340+cotes2020@users.noreply.github.com>
@cotes2020 cotes2020 merged commit 1719d81 into cotes2020:master Apr 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants