Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code #1327

Open
KangLin opened this issue Nov 24, 2023 · 0 comments
Open

Refactor the code #1327

KangLin opened this issue Nov 24, 2023 · 0 comments

Comments

@KangLin
Copy link
Contributor

KangLin commented Nov 24, 2023 •
edited
Loading

Refactor the code style

  1. Remove exit() and free resource
  2. Remove goto
  3. Optimized "{}" multiple nesting,
    Replace c89 (restrict variable declaration position at the beginning of the block)
    with c11 (no restriction variable declaration position in the block)
  4. Optimized the multiple nesting and length of if{}. see: Refactor: peer_input_handle #1325 Refactor: send_data_from_ioa_socket_nbh #1326
  5. The length of the function is optimized and divided into multiple single-function functions

refactor log

  1. Replace perror with TURN_LOG_FUNC
  2. Use a mature logging library #1344

Use cmake and remove configure

The current configure and Makefile.in is not standard automake. so it maintainability is bad.

Refactor the program flow
KangLin added a commit to KangLin/coturn that referenced this issue Nov 24, 2023
@KangLin
Refactor: peer_input_handle (coturn#1327)
2e451bb
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: create_server_listener (coturn#1327)
67d80b7 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
ce96775 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_listener to remove exit (coturn#1327)
01a62c9 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
a34986b 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
9861f2f 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
a1f8a58 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
194c6ef 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
4591e32 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
e3a3a75 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
8603067 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
33179fd 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_listener to remove exit (coturn#1327)
82a4ce3 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
b340a6a 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
9e645c6 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_listener to remove exit() (coturn#1327)
dd96b60 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
ba500c9 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
e933782 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_listener to remove exit() (coturn#1327)
2aa4dd1 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
9ab4837 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 27, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
66f5cc8 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: modify create_server_listener to remove exit() (coturn#1327)
350f778 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
5e3bea9 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
ef1dbac 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: modify create_server_listener to remove exit() (coturn#1327)
2a99c69 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: modify create_server_socket to coturn#1327
1153eff 
- Remove exit() and free resource
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
- Replace perror with TURN_LOG_FUNC
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
0259b9f 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
KangLin added a commit to KangLin/coturn that referenced this issue Nov 28, 2023
@KangLin
Refactor: addr_bind (coturn#1327)
88430b9 
- Remove goto
- Optimized "{}" multiple nesting,
- Replace c98 (restrict variable declaration position at the beginning of the block)
  with c11 (no restriction variable declaration position in the block)
  Optimized the multiple nesting and length of if{}.
@KangLin KangLin mentioned this issue Dec 7, 2023
Open
@KangLin KangLin changed the title Refactor the code style Refactor the code Jan 18, 2024
@KangLin KangLin mentioned this issue Jan 18, 2024
Closed
KangLin added a commit to KangLin/coturn that referenced this issue Apr 10, 2024
@KangLin
Refactor: peer_input_handle (coturn#1325)
4e94f67 
see: coturn#1327
KangLin added a commit to KangLin/coturn that referenced this issue Apr 10, 2024
@KangLin
Refactor: peer_input_handle (coturn#1325)
243b2d7 
see: coturn#1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KangLin