Always run lint, regardless of branch #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakraly
approved these changes
May 27, 2024
maddymeows
pushed a commit
to maddymeows/coturn
that referenced
this pull request
Jun 2, 2024
Someone working on a branch in their own fork won't see the lint running on their github-actions CI until they open a pull request. It'd be much easier to ensure changes being worked on are going to pass the linter if the linter runs before the last step of opening the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone working on a branch in their own fork won't see the lint running on their github-actions CI until they open a pull request.
It'd be much easier to ensure changes being worked on are going to pass the linter if the linter runs before the last step of opening the PR.