Include what you use #1512
Merged
Include what you use #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddymeows
pushed a commit
to maddymeows/coturn
that referenced
this pull request
Jun 2, 2024
Use the include-what-you-use program to (partially) clean up header includes, so that only includes which are needed, and no includes that are not needed (or at least closer to that ideal) are done. For a c-language project, the build-time improvements from this change is minimal. This would have a much bigger impact on a C++ project than a C-project for build times. So for coturn, this change is mostly intended to just provide consistency and make it easier to locate weird issues like strange dependencies, and unnecessary connections between code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the include-what-you-use program to (partially) clean up header includes, so that only includes which are needed, and no includes that are not needed (or at least closer to that ideal) are done.
For a c-language project, the build-time improvements from this change is minimal. This would have a much bigger impact on a C++ project than a C-project for build times.
So for coturn, this change is mostly intended to just provide consistency and make it easier to locate weird issues like strange dependencies, and unnecessary connections between code.