MB-49874 - bleveMaxClauseCount reset to 1024 after restart

Introducing new "OnRefreshManagerOptions" callback to
the ManagerEventHandlers interface so that clients can
get notified of any runtime config updates.

Change-Id: If177db5d4d2d6c25174ecb3492f406419e6e5892
Reviewed-on: https://review.couchbase.org/c/cbgt/+/169392
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Abhinav Dangeti <abhinav@couchbase.com>
Tested-by: Abhinav Dangeti <abhinav@couchbase.com>

manager.go

@@ -216,6 +216,7 @@ type ManagerEventHandlers interface {
 	OnRegisterPIndex(pindex *PIndex)
 	OnUnregisterPIndex(pindex *PIndex)
 	OnFeedError(srcType string, r Feed, err error)
+	OnRefreshManagerOptions(options map[string]string)
 }
 
 // NewManager returns a new, ready-to-be-started Manager instance.
@@ -1248,6 +1249,11 @@ func (mgr *Manager) RefreshOptions() error {
 	mgr.options = newOptions
 	log.Printf("manager: RefreshOptions: %+v finished", mgr.options)
 	mgr.optionsMutex.Unlock()
+	// invoke any manager option refresh callbacks.
+	if mgr.meh != nil {
+		mgr.meh.OnRefreshManagerOptions(newOptions)
+	}
+
 	return err
 }
 

manager_test.go

@@ -44,6 +44,9 @@ func (meh *TestMEH) OnFeedError(srcType string, r Feed,
 	err error) {
 }
 
+func (meh *TestMEH) OnRefreshManagerOptions(o map[string]string) {
+}
+
 func TestPIndexPath(t *testing.T) {
 	m := NewManager(VERSION, nil, NewUUID(), nil,
 		"", 1, "", "", "dir", "svr", nil)

rest/rest_test.go

@@ -79,6 +79,9 @@ func (meh *TestMEH) OnUnregisterPIndex(pindex *cbgt.PIndex) {
 func (meh *TestMEH) OnFeedError(srcType string, r cbgt.Feed, err error) {
 }
 
+func (meh *TestMEH) OnRefreshManagerOptions(o map[string]string) {
+}
+
 func TestNewRESTRouter(t *testing.T) {
 	emptyDir, _ := ioutil.TempDir("./tmp", "test")
 	defer os.RemoveAll(emptyDir)