This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Remove Android dependencies from shared code #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API breaking change. Applications must now call CBLite.init(Context) to initialize CBLite
pasin
suggested changes
Mar 19, 2019
| import java.lang.ref.SoftReference; | ||
|
|
||
|
|
||
| public final class CBLite { |
There was a problem hiding this comment.
I would suggest to use the full name, "CouchbaseLite" as it's emphasize the project name, and we try not to use abbreviation in the public API.
borrrden
reviewed
Mar 19, 2019
pasin
approved these changes
Mar 19, 2019
|
Ignoring the decrease in coverage. This is just a refactor and has, actually, no affect on coverage. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API breaking change.
Applications must now call CBLite.init(Context) to initialize CBLite