Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBL-3666: Connectivity Manager can be registered multiple times. #117

Merged
merged 2 commits into from Sep 9, 2022

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented Sep 9, 2022

Hotfix for CBSE-12499

When a continuous replication goes offline, it registers an observer to watch for changes in connectivity. The code used to allow a single observer to be registered multiple times. If this happened often enough, the system would throw an uncheck exception: TooManyRequestsException, which will cause the thread to fail.

The heart of the fix is line 313, checking to see if the observer is already in the map. The try-catch blocks are just bullet-proofing.

@bmeike bmeike self-assigned this Sep 9, 2022
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is a simple merge of something that already went out

@bmeike
Copy link
Contributor Author

bmeike commented Sep 9, 2022

@borrrden : it is not. I put this fixe in Helium first. It seems to work but, as noted, I do not have a good way to test it very thoroughly. I assumed that we would push the relevant customer to update to 3.0, so I put it in 3.0, next. That has not been released. I just got notification from Dan that we'll need a 2.8 VF. This will produce that VF.

@bmeike bmeike merged commit 9d62871 into android/release/hydrogen Sep 9, 2022
@bmeike bmeike deleted the android/hotfix/2.8.9.1 branch September 9, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants