Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigureAwait(false) not being used to resume without current co… #42

Closed
wants to merge 1 commit into from

Conversation

millerhederi
Copy link
Contributor

…ntext on awaits

@millerhederi
Copy link
Contributor Author

Creating a sample ASP.NET app that syncronously blocks on the Async method will produce a deadlock with the current implementation.

public ActionResult Load()
{
    UpsertAsync().GetAwaiter().GetResult();

    return Content("Loaded!");
}

private static async Task<IDocumentResult<string>>  UpsertAsync()
{
    return await Bucket.Value.UpsertAsync(new Document<string> { Id = "1", Content = "Content" }).ConfigureAwait(false);
}

@jeffrymorris
Copy link
Contributor

@millerhederi -

Thanks for the submission! If you haven't already done so, would you mind creating a Gerrit (our code review system: review.couchbase.com) account and signing the CLA? Here are the steps: http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes

Once you do that, I'll push this PR to Gerrit for review and it will be included in 2.2.0 next month assuming it is +2!

Thanks,

Jeff

@millerhederi
Copy link
Contributor Author

@jeffrymorris -

Hey Jeff, I went ahead and created an account on Gerrit and signed the CLA, hopefully should be good to go.

@millerhederi
Copy link
Contributor Author

@jeffrymorris - Is there any update on this? I have not received any notification that the PR has been pushed into Gerrit.

@jeffrymorris
Copy link
Contributor

@millerhederi -

I pushed it the PR to gerrit; there is a backlog of things to be reviewed and merged in gerrit, so it will take a bit of time before it's reviewed. The planned release date for 2.2.0 (the next release) is early October 2015.

-Jeff

@brett19 brett19 closed this Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants